Skip to content

Revert "CLN: Remove read_orc dtype checking (#51604)" #51742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 3, 2023
Merged

Revert "CLN: Remove read_orc dtype checking (#51604)" #51742

merged 4 commits into from
Mar 3, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Mar 2, 2023 •
edited by lukemanley
Loading

This reverts commit b69bd07.

Looks like timeouts started after this commit. Checking if this would fix it before looking closer

@phofl
Copy link
Member Author

phofl commented Mar 2, 2023 •
edited
Loading

Was able to reproduce locally, we get segfaults with pyarrow 7.0, 8.0 works as expected

@phofl phofl added CI Continuous Integration Arrow pyarrow functionality labels Mar 2, 2023
@phofl phofl added this to the 2.1 milestone Mar 2, 2023
@lukemanley
Copy link
Member

LGTM

@lukemanley lukemanley merged commit 56508fb into pandas-dev:main Mar 3, 2023
@lukemanley
Copy link
Member

thanks @phofl

@phofl phofl deleted the revert_orc_dtype_checking branch March 3, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lukemanley lukemanley lukemanley approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Arrow pyarrow functionality CI Continuous Integration
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

CI: min versions timeouts
2 participants
@phofl @lukemanley